Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 8, 2025


PR-Codex overview

This PR focuses on refactoring various components in the dashboard application to improve consistency, styling, and functionality. It also enhances form handling and updates UI elements for better user experience.

Detailed summary

  • Updated ThemeProvider to include enableColorScheme.
  • Changed SelectTrigger background class.
  • Refactored SolidityInput components to streamline props.
  • Modified error handling in forms, replacing isDisabled with disabled.
  • Enhanced styling for various UI components, including buttons and fieldsets.
  • Replaced FormControl with FormFieldSetup in multiple locations for consistency.
  • Updated import statements for better organization and clarity.
  • Improved accessibility and user feedback through better error messaging.
  • Adjusted layout and spacing in several components for better visual hierarchy.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 8, 2025

@vercel
Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 4:12pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 9, 2025 4:12pm
login ⬜️ Skipped (Inspect) Feb 9, 2025 4:12pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 9, 2025 4:12pm
wallet-ui ⬜️ Skipped (Inspect) Feb 9, 2025 4:12pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 8, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review February 8, 2025 14:28
@MananTank MananTank requested review from a team as code owners February 8, 2025 14:28
@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2025

⚠️ No Changeset found

Latest commit: c86e13b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.28 KB (0%) 926 ms (0%) 881 ms (+139.49% 🔺) 1.9 s
thirdweb (cjs) 122.06 KB (0%) 2.5 s (0%) 1.6 s (+26.48% 🔺) 4 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 66 ms (-25.18% 🔽) 178 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 21 ms (+128.92% 🔺) 31 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 197 ms (+66.37% 🔺) 583 ms

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 8, 2025 20:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 8, 2025 20:18 Inactive
@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (bc42c2f) to head (c86e13b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6211   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files        1161     1161           
  Lines       64289    64289           
  Branches     5196     5196           
=======================================
  Hits        36468    36468           
  Misses      27095    27095           
  Partials      726      726           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from bc42c2f
packages 54.89% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 9, 2025

Merge activity

  • Feb 9, 9:43 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 9, 9:52 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Vercel – thirdweb-www').
  • Feb 9, 11:12 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 9, 11:13 AM EST: A user merged this pull request with the Graphite merge queue.

graphite-app bot pushed a commit that referenced this pull request Feb 9, 2025
…akra Usage (#6211)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on refining the UI components and improving the overall structure of the contract deployment forms. It introduces new styles, modifies existing components, and enhances accessibility.

### Detailed summary
- Updated `ThemeProvider` to enable color scheme.
- Changed class names for various components to improve styling.
- Simplified props for `SolidityInput` components.
- Replaced `FormControl` with `FormFieldSetup` for better structure.
- Enhanced accessibility by modifying error messages and labels.
- Streamlined imports and removed unnecessary components.
- Improved the layout and styling of various fieldsets and buttons.
- Added new utility functions for better handling of form states.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – login February 9, 2025 14:44 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 9, 2025 14:44 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 9, 2025 14:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 9, 2025 14:44 Inactive
…akra Usage (#6211)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on refining the UI components and improving the overall structure of the contract deployment forms. It introduces new styles, modifies existing components, and enhances accessibility.

### Detailed summary
- Updated `ThemeProvider` to enable color scheme.
- Changed class names for various components to improve styling.
- Simplified props for `SolidityInput` components.
- Replaced `FormControl` with `FormFieldSetup` for better structure.
- Enhanced accessibility by modifying error messages and labels.
- Streamlined imports and removed unnecessary components.
- Improved the layout and styling of various fieldsets and buttons.
- Added new utility functions for better handling of form states.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 9, 2025 16:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 9, 2025 16:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 9, 2025 16:06 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 9, 2025 16:06 Inactive
@graphite-app graphite-app bot merged commit c86e13b into main Feb 9, 2025
33 checks passed
@graphite-app graphite-app bot deleted the TOOL-3366 branch February 9, 2025 16:13
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 9, 2025 16:13 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 9, 2025 16:13 Inactive
@vercel vercel bot temporarily deployed to Production – login February 9, 2025 16:13 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 February 9, 2025 16:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants